Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exitcrash argument to cleanly exit debugger #1093

Closed
wants to merge 1 commit into from
Closed

add exitcrash argument to cleanly exit debugger #1093

wants to merge 1 commit into from

Conversation

chesshacker
Copy link

The --exitcrash argument can save you from having to manually kill the nodemon process.

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@chesshacker
Copy link
Author

Sorry. I thought this argument would prevent you from needing to kill the launched process, but it's only a partial fix. This fix only works as intended when no changes have been made to the watched files. If nodemon has restarted your application, then stopping the debugger fails to stop the process. I would love to find a solution to this that works all the time, but this isn't it.

I still like the --exitcrash argument because it saves me from having to kill the process some of the time... but the Tip I removed should probably be added back, and maybe it should be revised to explain that sometimes you must still kill the process manually.

Please let me know if you'd prefer I close this PR or adjust it. Thanks!

@roblourens
Copy link
Member

I didn't know about the --exitcrash argument, thanks for the tip. I can confirm that it saves me from having to kill nodemon but only when I haven't changed any files.

I would find it useful but I'd like to keep the recommended configuration simple, and don't want to explain that switch in the docs, so I'll close this for now. FYI @weinand, in case you'd like to keep this switch in the docs.

@roblourens roblourens closed this Jul 18, 2017
@weinand
Copy link
Contributor

weinand commented Jul 18, 2017

Thanks for the tip. I didn't know either.
I'm planning a nodemon recipe, so I might mention it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants