Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intro to git #5677

Merged
merged 12 commits into from
Feb 22, 2023
Merged

Intro to git #5677

merged 12 commits into from
Feb 22, 2023

Conversation

digitarald
Copy link
Contributor

@digitarald digitarald commented Oct 3, 2022 •
edited
Loading

  • Add screenshots

@digitarald digitarald marked this pull request as draft October 3, 2022 17:38
@kieferrm kieferrm mentioned this pull request Oct 8, 2022
Closed
77 tasks
@digitarald digitarald added this to the October 2022 milestone Oct 12, 2022
@gregvanl gregvanl modified the milestones: October 2022, November 2022 Oct 26, 2022
@kieferrm kieferrm mentioned this pull request Nov 6, 2022
Closed
@digitarald digitarald marked this pull request as ready for review December 12, 2022 18:35
@kieferrm kieferrm mentioned this pull request Jan 2, 2023
Closed
@kieferrm kieferrm mentioned this pull request Feb 4, 2023
Closed
92 tasks
@microsoft microsoft deleted a comment from gregvanl Feb 17, 2023
@microsoft microsoft deleted a comment from gregvanl Feb 17, 2023
@digitarald
Copy link
Contributor Author

@gregvanl it took on its final form after some hibernation! As I did some more text edits, a final editorial review would be much appreciated.

@gregvanl
Copy link

@digitarald Some of the images look pixelated such as sync.png and timeline.png. The others look crisp. Was the compression too aggressive on those two?

@digitarald
Copy link
Contributor Author

digitarald commented Feb 22, 2023 •
edited
Loading

@digitarald Some of the images look pixelated such as sync.png and timeline.png. The others look crisp. Was the compression too aggressive on those two?

Weird. I suspect I took those screenshots on a MDPI screen, while others are from a HDPI screen. Re-exporting from Figma … ✅ Done

gregvanl
gregvanl reviewed Feb 22, 2023
View reviewed changes
docs/sourcecontrol/intro-to-git.md

![Creating a Codespace from a repo within desktop VS Code](images/intro/codespace-create.png)

Alternatively, you can also start from a template from the [GitHub's Codespaces site](https://github.com/codespaces/templates). If you already have a Codespace open in your browser, you can open it in your Desktop VS Code by running the **Codespaces: Open in VS Code Desktop** command. Learn more about Codespaces to forwarding ports.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there text missing on the paragraph's last sentence? Was this to be a link to the Codespaces documentation?
Something like "You can learn more in the Codespaces documentation, including features like {blah} and forwarding ports."

gregvanl
gregvanl approved these changes Feb 22, 2023
View reviewed changes
Copy link

@gregvanl gregvanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
We can have a look on the staging server and I'll also create a follow up PR with format and small edits

@gregvanl gregvanl merged commit c6c4241 into main Feb 22, 2023
@gregvanl gregvanl deleted the digitarald/git-intro branch February 22, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregvanl gregvanl gregvanl approved these changes

Assignees

@digitarald digitarald

Labels
None yet
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@digitarald @gregvanl @theReynald