Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ACI references #5710

Merged
merged 5 commits into from
Nov 28, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 0 additions & 19 deletions docs/containers/app-service.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ In this guide you will learn how to:
- Create a container image for your application.
- Push the image to a container registry.
- Deploy the image to Azure App Service.
- Deploy the image to Azure Container Instances (ACI).

## Prerequisites

Expand Down Expand Up @@ -89,24 +88,6 @@ In the previous section, the image is pushed to a remote container registry. Now

![Web Application](images/app-service/webapp-homepage.png)

## Deploy to ACI

In the previous section, the image was deployed to Azure App Service. Another option is to deploy the image to [Azure Container Instances (ACI)](https://azure.microsoft.com/services/container-instances/). First, deploy the container to a container registry, such as Docker Hub or ACR, as described earlier in this article. Then, find the container in the **Registries** section of the Docker Explorer. Use the **Refresh** button if you don't see it there. Right-click the entry for the image you want, and choose **Deploy image to Azure Container Instances**.

![Deploy to ACI menu item](images/app-service/deploy-aci-menu.png)

Choose an existing context, or use **Create new ACI Context**, and then choose the resource group. The container is started in ACI.

The context you created is displayed in the **Contexts** pane in the Docker Explorer and selected as the active context. Whichever context is the active one affects the images shown in the **Containers** pane.

![ACI in contexts pane](images/app-service/deploy-aci-contexts.png)

When the image finishes the start-up process and becomes available, an entry for the image appears in the **Containers** pane. You can then manage the container instance by right-clicking on the entry. For example, to monitor the logs, choose **View Logs**.

![Manage images in the Containers pane](images/app-service/deploy-aci-containers-pane.png)

If it's a web app, you can use **Open in Browser** to navigate to the app's homepage. When you're done with the instance, right-click the instance name, and choose **Remove**. Because billing in ACI is by the second and only when the container is running, as soon as you remove it, you are no longer accruing charges.

## Next steps

Read on to learn more about
Expand Down
11 changes: 3 additions & 8 deletions docs/containers/reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ You have two options for configuring each of the templates (listed below). The f
}
```

The second option is multiple templates that will be chosen based on the `match` regular expression, the `contextTypes` in which it is applicable, as well as user input. The `contextTypes` property is a list of Docker context types in which a command template applies. If it is undefined or empty, the template is applicable in all Docker contexts.
The second option is multiple templates that will be chosen based on the `match` regular expression, as well as user input.

For example, three templates are shown in the following example:

Expand All @@ -499,11 +499,6 @@ For example, three templates are shown in the following example:
"label": "Alpine-specific build command",
"template": "docker build -p 1234:1234 -f \"${dockerfile}\" -t ${tag} \"${context}\"",
"match": "alpine"
},
bwateratmsft marked this conversation as resolved.
Show resolved Hide resolved
{
"label": "Context-specific build command",
"template": "docker build -f \"${dockerfile}\" .",
"contextTypes": ["moby"]
}
]
}
Expand All @@ -516,9 +511,9 @@ The command template chosen to execute is selected based on the following rules:
1. If no setting is configured, the default command template is chosen.
1. If only a single template is configured (the first example above), that template is chosen.
1. If multiple templates are configured:
1. Constrained templates are checked. A constrained template has either `match` or `contextTypes`, or both. The `match` regular expression is compared against contextual hints--for example, image name, container name, etc. The `contextTypes` property causes the template to apply only in certain context types, for example, `moby` or `aci` (or both).
1. Constrained templates are checked. A constrained template has `match`. The `match` regular expression is compared against contextual hints--for example, image name, container name, etc.
1. If multiple constrained templates apply, the user will be prompted to choose. If only one applies, the user will not be prompted.
1. If there no applicable constrained templates, unconstrained templates are checked. An unconstrained template has neither `match` nor `contextTypes`, and is therefore always applicable.
1. If there no applicable constrained templates, unconstrained templates are checked. An unconstrained template does not have `match`, and is therefore always applicable.
1. If multiple unconstrained templates apply, the user will be prompted to choose. If only one applies, the user will not be prompted.

### Docker Build
Expand Down