Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating devtools panel to show webview #3

Merged
merged 4 commits into from
Mar 21, 2019

Conversation

jalissia
Copy link
Member

This PR adds code to the devtools panel that will show a webview pointed at the devtools.html.

  • Implemented DevToolsPanel class to create the webview
  • Added messaging proxy code that will transfer messages between the extension frame and the devtools frame
  • Added more unit tests

Now when you select a target a blank webview will open up in a new tab. WebView content will come in future PR.
vscode-edge-devtools-blank-webview

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I would prefer fishing the values out of the mocks instead of assigning to parent scope variables directly.

src/devtoolsPanel.test.ts Outdated Show resolved Hide resolved
src/devtoolsPanel.test.ts Show resolved Hide resolved
src/devtoolsPanel.test.ts Outdated Show resolved Hide resolved
src/host/messaging.ts Outdated Show resolved Hide resolved
@jalissia jalissia merged commit e5cbde2 into master Mar 21, 2019
@jalissia jalissia deleted the user/jalissia/devtools-panel branch March 21, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants