Bubbling up close message from websocket to the extension. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalissia
suggested changes
Aug 6, 2019
jalissia
reviewed
Aug 6, 2019
Detects if the close event has been triggered and the dispose function handled.
jalissia
reviewed
Aug 6, 2019
jalissia
reviewed
Aug 6, 2019
| @@ -161,10 +161,14 @@ describe("devtoolsPanel", () => { | |||
| const dtp = await import("./devtoolsPanel"); | |||
| dtp.DevToolsPanel.createOrShow(context, mockTelemetry, "", mockRuntimeConfig); | |||
|
|
|||
| expect(mockPanelSocket.on).toHaveBeenCalledTimes(Object.keys(webviewEventNames).length); | |||
| expect(mockPanelSocket.on).toHaveBeenCalledTimes(Object.keys(webviewEventNames).length + 1); | |||
There was a problem hiding this comment.
Add a small comment to explain the +1 E.g. // +1 for 'close' event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bubbles up the close message from the websocket to the extension, so when the websocket is closed the extension will be closed too.