fix: mark successive dots as noise and invalidate jinja syntax abbreviations #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
…date Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
iifawzi
force-pushed
the
fix/jinga-successive--abbreviations
branch
from
39c430e
to
3bcd26e
Compare
|
Hi @rzhao271, would appreciate if you can take a look whenever you have a time |
rzhao271
reviewed
Jun 7, 2023
… successive dots Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
|
Pushed the changes https://github.com/iifawzi/vscode-emmet-helper/tree/fix/jinga-successive--abbreviations, but for some reason they didn't reflect here. That's weird, I've never encountered this. EDIT: ok it seems like there's an outage, https://www.githubstatus.com/ |
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
iifawzi
force-pushed
the
fix/jinga-successive--abbreviations
branch
from
be23333
to
cb173b7
Compare
rzhao271
approved these changes
Jun 7, 2023
joyceerhl
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR should fix microsoft/vscode#179422
let me know if it could be done in any better way