-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mark successive dots as noise and invalidate jinja syntax abbreviations #80
fix: mark successive dots as noise and invalidate jinja syntax abbreviations #80
Conversation
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
…date Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
39c430e
to
3bcd26e
Compare
Hi @rzhao271, would appreciate if you can take a look whenever you have a time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I have added some comments
… successive dots Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
Pushed the changes https://github.com/iifawzi/vscode-emmet-helper/tree/fix/jinga-successive--abbreviations, but for some reason they didn't reflect here. That's weird, I've never encountered this. EDIT: ok it seems like there's an outage, https://www.githubstatus.com/ |
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
be23333
to
cb173b7
Compare
Hi, this PR should fix microsoft/vscode#179422
let me know if it could be done in any better way