Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonschema: eslint.codeActionsOnSave.mode has no default #79

Closed
Morriz opened this issue Nov 13, 2020 · 12 comments
Closed

jsonschema: eslint.codeActionsOnSave.mode has no default #79

Morriz opened this issue Nov 13, 2020 · 12 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@Morriz
Copy link

Morriz commented Nov 13, 2020

Maybe this escaped attention? Me so nitpick ;p

@Morriz
Copy link
Author

Morriz commented Nov 13, 2020

Version: 1.51.0
Commit: fcac248b077b55bae4ba5bab613fd6e9156c2f0c
Date: 2020-11-05T18:14:40.758Z (1 wk ago)
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 19.6.0

@dbaeumer
Copy link
Member

Hmm, it does: https://github.com/microsoft/vscode-eslint/blob/master/package.json#L370

Can you clarify what you mean.

@Morriz
Copy link
Author

Morriz commented Nov 17, 2020

Thanks for the quick reply.

But I don't see it:

Screen Shot 2020-11-16 at 17 14 25

Screen Shot 2020-11-17 at 14 28 43

@Morriz
Copy link
Author

Morriz commented Nov 17, 2020

Maybe it's a yaml extension quirk. They have some when it comes to enum types and default values.

@dbaeumer
Copy link
Member

Can you explain what to expect to see.

@Morriz
Copy link
Author

Morriz commented Nov 18, 2020

Sure, try any other boolean: it will show the word "default" top right for one that is set as such.

@Morriz
Copy link
Author

Morriz commented Nov 18, 2020

Screen Shot 2020-11-18 at 11 19 26

@Morriz
Copy link
Author

Morriz commented Nov 18, 2020

I see a lot of the spec's defaults are not showing this now...but some are...very strange

@dbaeumer
Copy link
Member

@aeschli do you know when we show the default value in the code complete. I did define it here: https://github.com/microsoft/vscode-eslint/blob/master/package.json#L370

@aeschli
Copy link
Contributor

aeschli commented Nov 19, 2020

Yes, that should work.

@dbaeumer
Copy link
Member

@aeschli do you know why it doesn't. See screen shot here: https://github.com/microsoft/vscode-eslint/issues/1112#issuecomment-728929799

@aeschli aeschli transferred this issue from microsoft/vscode-eslint Nov 19, 2020
@aeschli aeschli added this to the November 2020 milestone Nov 19, 2020
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Nov 19, 2020
@dbaeumer
Copy link
Member

@aeschli thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants