Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lsp-embedded-language-serviceadd add activationEvents to invoke client #936

Merged
merged 1 commit into from
May 6, 2024

Conversation

moushicheng
Copy link
Contributor

@moushicheng moushicheng commented Dec 30, 2023

What Happen?

it's seem that vscode high version can't work in lsp-embedded-language-service

Why Happen?

i find some clues in official document

Note: If your extension is compatible with VS Code versions prior to 1.74.0, you must declare onLanguage:plaintext in the activationEvents field of /package.json to tell VS Code to activate the extension as soon as a plain text file is opened (for example a file with the extension .txt):

beacuse lack of activationEvents, it is origin activationEvents config

	"activationEvents": [],

How to Fix?

	"activationEvents": [
		"onLanguage:html1"
	],

Other

I've found that other people have the same problem

https://stackoverflow.com/questions/77038821/why-can-i-not-run-the-lsp-embedded-language-service-example-how-should-i-debug

@daKmoR
Copy link

daKmoR commented Mar 2, 2024

just stumbled over this myself - this fixes it indeed 🤗

@apupier
Copy link

apupier commented Mar 7, 2024

fixes #952

@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone May 6, 2024
@aeschli aeschli enabled auto-merge May 6, 2024 10:22
@aeschli aeschli merged commit 12375b5 into microsoft:main May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants