Allow undefined for measurements (#203)

microsoft · Mar 20, 2024 · 2ad7b6e · 2ad7b6e
1 parent de8e93a
commit 2ad7b6e
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 44 deletions.
diff --git a/dist/telemetryReporter.d.ts b/dist/telemetryReporter.d.ts
@@ -7,7 +7,7 @@ export interface TelemetryEventProperties {
 }
 
 export interface TelemetryEventMeasurements {
-	readonly [key: string]: number;
+	readonly [key: string]: number | undefined;
 }
 
 /**

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@vscode/extension-telemetry",
   "description": "A module for Visual Studio Code extensions to report consistent telemetry.",
-  "version": "0.9.3",
+  "version": "0.9.4",
   "author": {
     "name": "Microsoft Corporation"
   },
@@ -20,9 +20,9 @@
     "compile": "tsc -p src/browser/tsconfig.json && tsc -p src/node/tsconfig.json"
   },
   "dependencies": {
-    "@microsoft/1ds-core-js": "^4.1.0",
-    "@microsoft/1ds-post-js": "^4.1.0",
-    "@microsoft/applicationinsights-web-basic": "^3.1.0"
+    "@microsoft/1ds-core-js": "^4.1.1",
+    "@microsoft/1ds-post-js": "^4.1.1",
+    "@microsoft/applicationinsights-web-basic": "^3.1.1"
   },
   "devDependencies": {
     "@types/mocha": "^10.0.3",

diff --git a/src/common/1dsClientFactory.ts b/src/common/1dsClientFactory.ts
@@ -52,7 +52,7 @@ const getAICore = async (key: string, vscodeAPI: typeof vscode, xhrOverride?: IX
 	appInsightsCore.addTelemetryInitializer((envelope: any) => {
 		envelope["ext"] = envelope["ext"] ?? {};
 		envelope["ext"]["web"] = envelope["ext"]["web"] ?? {};
-		envelope["ext"]["web"]["consentDetails"] = '{"GPC_DataSharingOptIn":false}';
+		envelope["ext"]["web"]["consentDetails"] = "{\"GPC_DataSharingOptIn\":false}";
 
 		// Only add the remaining flags when `telemetry.internalTesting` is enabled
 		if (!internalTesting) {

diff --git a/test/baseTelemetrySender.test.ts b/test/baseTelemetrySender.test.ts
@@ -75,28 +75,28 @@ describe("Base telemetry sender test suite", () => {
 			assert.strictEqual((telemetryClient.logEvent as sinon.SinonSpy).callCount, 1);
 			sinon.assert.calledWithMatch(
 				telemetryClient.logEvent as sinon.SinonSpy, "unhandlederror",
-				{properties: {name: error.name, message: error.message, stack: error.stack}}
+				{ properties: { name: error.name, message: error.message, stack: error.stack } }
 			);
-		})
+		});
 
 		it("Error properties are correctly created for a data without properties field", () => {
 			const error = new Error("test");
-			sender.sendErrorData(error, {prop1: 1, prop2: "two"});
+			sender.sendErrorData(error, { prop1: 1, prop2: "two" });
 			assert.strictEqual((telemetryClient.logEvent as sinon.SinonSpy).callCount, 1);
 			sinon.assert.calledWithMatch(
 				telemetryClient.logEvent as sinon.SinonSpy, "unhandlederror",
-				{properties: {prop1: 1, prop2: "two", name: error.name, message: error.message, stack: error.stack}}
+				{ properties: { prop1: 1, prop2: "two", name: error.name, message: error.message, stack: error.stack } }
 			);
 		});
 
 		it("Error properties are correctly created for a data with properties field", () => {
 			const error = new Error("uh oh");
-			sender.sendErrorData(error, {properties: {prop1: 1, prop2: "two"}});
+			sender.sendErrorData(error, { properties: { prop1: 1, prop2: "two" } });
 			assert.strictEqual((telemetryClient.logEvent as sinon.SinonSpy).callCount, 1);
 			sinon.assert.calledWithMatch(
 				telemetryClient.logEvent as sinon.SinonSpy, "unhandlederror",
-				{properties: {prop1: 1, prop2: "two", name: error.name, message: error.message, stack: error.stack}}
+				{ properties: { prop1: 1, prop2: "two", name: error.name, message: error.message, stack: error.stack } }
 			);
 		});
-	})
+	});
 });