Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Allow to run tests with insiders build #88

Closed
guw opened this issue Nov 29, 2017 · 10 comments
Closed

Allow to run tests with insiders build #88

guw opened this issue Nov 29, 2017 · 10 comments

Comments

@guw
Copy link
Contributor

guw commented Nov 29, 2017

It's currently not possible to run VS Code Extension tests with an insiders build.

Looking at the code it seems that setting CODE_VERSION should do the trick. However, this doesn't work because of a hard coded "stable" in the generated download url. Also, setting CODE_DOWNLOAD_URL directly (eg., to https://vscode-update.azurewebsites.net/1.19.0-insider/linux-x64/insider) won't help. The resulting executable name would be code-insiders, which isn't currently supported.

@guw
Copy link
Contributor Author

guw commented Nov 30, 2017

@bpasero I noticed that setting CODE_DOWNLOAD_URL isn't a valid workaround. The executable after the download is code-insiders, which the test script doesn't support currently.

@bpasero
Copy link
Member

bpasero commented Nov 30, 2017

Ah yeah good point.

@bpasero
Copy link
Member

bpasero commented Dec 1, 2017

@joaomoreno would it be possible to get an endpoint in the form of: https://vscode-update.azurewebsites.net/<platform>/insiders that would simply return the last insiders release?

guw added a commit to forcedotcom/salesforcedx-vscode that referenced this issue Dec 1, 2017
guw added a commit to forcedotcom/salesforcedx-vscode that referenced this issue Dec 1, 2017
* Use Trusty image for build
* Use XCode 9.1
* Bump vscode version to 1.1.8
* Update codecov ignored paths
* Disable gcov on AppVeyor (causes long path issues)
* Allow Linux builds to fail
* Setting CODE_DOWNLOAD_URL won't help

With all the tweaks the macOS builds seem to run more reliably then the Linux builds. However, the performance varies because of limites macOS capacity. This is covered in our GitHub setup already by not requiring the Travis build to pass for PRs.

See also microsoft/vscode-extension-vscode#88
@joaomoreno
Copy link
Member

@bpasero
Copy link
Member

bpasero commented Dec 1, 2017

@joaomoreno that one downloads stable for me. How does the website get the latest insider build from https://code.visualstudio.com/insiders/ ?

@joaomoreno
Copy link
Member

Oh https://vscode-update.azurewebsites.net/latest/win32/insider. There was an S too many.

@bpasero
Copy link
Member

bpasero commented Dec 4, 2017

@joaomoreno thanks

@guw interested to provide this as PR? I think we should just use the insider build when the extension declares "*" as engine dependency. E.g.

"engines": {
    "vscode": "*"
}

@guw
Copy link
Contributor Author

guw commented Dec 4, 2017

@bpasero According to the docs * is not allowed. Should it be used anyway? Won't that cause issues at runtime?

@bpasero
Copy link
Member

bpasero commented Dec 4, 2017

@guw yeah good point, it would probably only be useful on a branch where you want to run builds and tests explicitly against insiders.

Alternatively we could introduce another environment variable to specify the build to be insiders.

guw added a commit to guw/vscode-extension-vscode that referenced this issue Dec 4, 2017
This change allows setting CODE_VERSION to 'insiders' which will trigger
download of an Insiders build and using that for test execution.

Fixes microsoft#88.

Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
@bpasero
Copy link
Member

bpasero commented Dec 5, 2017

Published as 1.1.10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants