Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tslint with eslint #187

Closed
wants to merge 3 commits into from
Closed

Conversation

badsyntax
Copy link

@badsyntax badsyntax commented Dec 8, 2019

Refs: #166

This change replaces tslint with eslint and uses the recommended rules provided by the @typescript-eslint plugin.

It also adds an option to add prettier as an eslint plugin. If enabled, prettier will be run through eslint, meaning formatting errors will be surfaced (and fixed) through eslint. You can see an example of how the project is genereated with prettier: https://github.com/badsyntax/vscode-generator-eslint-prettier-example

This approach is somewhat similar to the existing ext-command-js eslint setup, although there's no prettier option for that type. (Do you want me to add prettier to ext-command-js as part of this PR?)

@msftclas
Copy link

msftclas commented Dec 8, 2019

CLA assistant check
All CLA requirements met.

@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2020

Fixed by #192

@aeschli aeschli closed this Jan 31, 2020
@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2020

Thanks for the work, @badsyntax , sorry for taking #192 instead, which is a bit simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants