Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template consistency pass #360

Merged
merged 9 commits into from
Jul 27, 2022

Conversation

hawkticehurst
Copy link
Member

Resolves #359

Includes the following changes:

  • Fix capitalization in the root package.json description
  • Remove extra empty line from gitattributes files
  • Update all gitignore, gitattribute, and vscodeignore that are not dotfiles to be dotfiles
  • Change all instances of CMD to Cmd
  • Change all instances of 'VSCode' to 'VS Code'
  • Update template README files to be more consistent with each other in terms of formatting and content
  • Fix various typos, formatting, and grammar issues in vsc-extension-quickstart files

@hawkticehurst
Copy link
Member Author

cc @daviddossett / @misolori / @aeschli

@hawkticehurst
Copy link
Member Author

Looks like CI testing failed because gitattribute (no dotfile) is part of the test suite (so I'm happy to revert my changes on that).

But I suppose it's a good time to double-check why only some of gitignore, gitattribute, and vscodeignore files are dotfiles and others are not?

@aeschli aeschli self-requested a review July 27, 2022 21:22
@aeschli aeschli self-assigned this Jul 27, 2022
@aeschli
Copy link
Contributor

aeschli commented Jul 27, 2022

Update all gitignore, gitattribute, and vscodeignore that are not dotfiles to be dotfiles

That also requires updating the generator scripts. Note: the user never saw the dotless files.

@aeschli aeschli added this to the July 2022 milestone Jul 27, 2022
@aeschli aeschli merged commit c8b99eb into microsoft:main Jul 27, 2022
@hawkticehurst hawkticehurst deleted the hawkticehurst/consistency-pass branch July 27, 2022 22:33
@hawkticehurst
Copy link
Member Author

That also requires updating the generator scripts. Note: the user never saw the dotless files.

Ahh, thanks for clarifying and for contributing a change to address this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do a consistency pass on extension templates
3 participants