Do not suggest function parameters if passing it as an argument (#1788)

* do not suggest function parameters if passing it as an argument * perform check only when suggestion class is variable
microsoft · Jul 17, 2018 · 43613e0 · 43613e0
1 parent 81e7053
commit 43613e0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/goSuggest.ts b/src/goSuggest.ts
@@ -203,7 +203,7 @@ export class GoCompletionItemProvider implements vscode.CompletionItemProvider {
 								);
 							}
 							if ((config['useCodeSnippetsOnFunctionSuggest'] || config['useCodeSnippetsOnFunctionSuggestWithoutType'])
-								&& (suggest.class === 'func' || suggest.class === 'var' && suggest.type.startsWith('func('))) {
+								&& (suggest.class === 'func' || suggest.class === 'var' && suggest.type.startsWith('func(') && lineText.substr(position.character, 1) !== ')' && lineText.substr(position.character, 1) !== ',')) {
 								let { params, returnType } = getParametersAndReturnType(suggest.type.substring(4));
 								let paramSnippets = [];
 								for (let i = 0; i < params.length; i++) {
@@ -398,4 +398,4 @@ export class GoCompletionItemProvider implements vscode.CompletionItemProvider {
 			return matchingPackages[0];
 		}
 	}
-}
+}