Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

1.7 formatOnSave Deprecated #611

Closed
caibirdme opened this issue Nov 10, 2016 · 10 comments
Closed

1.7 formatOnSave Deprecated #611

caibirdme opened this issue Nov 10, 2016 · 10 comments

Comments

@caibirdme
Copy link

caibirdme commented Nov 10, 2016

go.formatOnSave deprecated from vscode 1.7
set your global config editor.formatOnSave to true if you like


can't be better to add this to doc or changelog

@Pitchanon
Copy link

Pitchanon commented Nov 10, 2016

Thank you.

@helinwang
Copy link

It's "editor.formatOnSave": true, in my vs code. (not edit.formatOnSave)

@caibirdme
Copy link
Author

@helinwang Sorry for my careless, u r right

@tilinna
Copy link

tilinna commented Nov 10, 2016

I wouldn't like to enable formatting on all languages. Therefore, I suggest the go.formatOnSave to function like previously until microsoft/vscode#13547 is fixed.

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Nov 10, 2016

@caibirdme A note on deprecating go.formatOnSave in favour of editor.formatOnSave was added to the Changelog during the release, but I had forgotten to add it to the README which is now updated as well.
Did you open this issue for the missing documentation or something else?

@tilinna I'd like to see if more from the community feel the same way. If yes, then I'll circle back to this nexst week.

@neelance
Copy link
Contributor

I just tried editor.formatOnSave and it completely broke it for me, because I don't want to format our TypeScript and our JSON files, only Go. I found no way to only make it happen for Go. The only way to continue working was to disable formatOnSave entirely. I'd say this is a regression and makes this feature unusable. It is especially bad since formatting on save is an expected default in the Go world.

@ramya-rao-a
Copy link
Contributor

This change has been reverted due to popular demand in the latest update. Will wait for VS Code to come up with language specific formatOnSave setting.

@neelance
Copy link
Contributor

Thanks for fixing this so quickly!

@ramya-rao-a
Copy link
Contributor

@neelance No problem
Thanks for reporting issues and pain points. I learn something new each day :)

@DasJott
Copy link

DasJott commented Dec 15, 2016

The editor.formatOnSave almost broke one of our releases as we use a selfmade template markup in our js and html and that was "formatted" which destroyed the whole page.
The GO formater always worked great, why not leave it as it is...

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants