Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Do not suggest function parameters if passing it as an argument #1788

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Do not suggest function parameters if passing it as an argument #1788

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
507a2ea
do not suggest function parameters if passing it as an argument
Jul 15, 2018
7a178d1
perform check only when suggestion class is variable
Jul 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/goSuggest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export class GoCompletionItemProvider implements vscode.CompletionItemProvider {
}
// Avoid adding snippet for function suggest when cursor is followed by ()
// i.e: met() -> method()()
if (lineText.substr(position.character, 2) !== '()') {
if (lineText.substr(position.character, 2) !== '()' && lineText.substr(position.character, 1) !== ')' && lineText.substr(position.character, 1) !== ',') {
item.insertText = new vscode.SnippetString(suggest.name + '(' + paramSnippets.join(', ') + ')');
}
}
Expand Down Expand Up @@ -390,4 +390,4 @@ export class GoCompletionItemProvider implements vscode.CompletionItemProvider {
return matchingPackages[0];
}
}
}
}