Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nested gradle projects #88

Merged
merged 7 commits into from
Dec 13, 2019
Merged

Add support for nested gradle projects #88

merged 7 commits into from
Dec 13, 2019

Conversation

badsyntax
Copy link
Collaborator

@badsyntax badsyntax commented Dec 12, 2019

Refs #86

This adds support for detecting gradle projects in nested subdirectories. I might make this configurable...

Screenshots

Here is the latest changes with nested gradle projects grouped by relative folder name. This is done to prevent conflict with sub-projects which are displayed at the workspace root.

Screenshot 2019-12-12 at 21 45 45

Example of deeply nested projects:

Screenshot 2019-12-12 at 21 53 43

Here is the flutter project, grouped by "android" directory name:

Screenshot 2019-12-12 at 21 46 29

Here is a gradle project without nested root project directories but with subprojects:

Screenshot 2019-12-12 at 21 47 18

Here is the final UI showing how the tasks are labelled in the command pallet:

Screenshot 2019-12-13 at 21 37 29

TODO

  • Add some basic tests

@badsyntax
Copy link
Collaborator Author

TODO: fix the duplicated gradle task descriptions in the command pallet:

Screenshot 2019-12-12 at 22 01 29

@badsyntax badsyntax added the enhancement New feature or request label Dec 12, 2019
@badsyntax
Copy link
Collaborator Author

I want to do explore the possibility of not making the task name noisy, but instead utilizing task descriptions. That way the explorer won't be noisy with redundant information, and it will be clear which task belongs to which project in the command pallet.

@badsyntax
Copy link
Collaborator Author

I can't add task details, this seems to be an internal thing (the npm extension sets task.detail but it's of type vscode.Task2 which is not exposed).

@badsyntax badsyntax changed the title Search for gradle projects in nested directories Add support for nested gradle projects Dec 13, 2019
Copy link
Collaborator Author

@badsyntax badsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badsyntax badsyntax merged commit ec9be84 into master Dec 13, 2019
@badsyntax badsyntax deleted the nested-roots branch December 13, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant