Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add copy selection as different formats and paste hexstring support #498

Merged
merged 7 commits into from
May 8, 2024

Conversation

lorsanta
Copy link
Contributor

Ref #411 and #341.

I added a copyAs command accessible from the context menus when right-clicking within the webview.
The different copyAs functions in copyAs.ts come from here https://github.com/stef-levesque/vscode-hexdump.

I’ve also introduced an encoding option that enables the pasting of hex strings, in addition to utf-8 and base64 strings.

@lorsanta lorsanta mentioned this pull request May 3, 2024
@lorsanta
Copy link
Contributor Author

lorsanta commented May 3, 2024

As I wrote here #521 (comment), because of #521 I think now it makes sense to rename all occurrences of copyAs to copyValueAs.
What do you think?

Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, sorry for the late review. Some comments.

src/copyAs.ts Outdated Show resolved Hide resolved
src/copyAs.ts Outdated Show resolved Hide resolved
src/copyAs.ts Outdated Show resolved Hide resolved
shared/protocol.ts Outdated Show resolved Hide resolved
src/copyAs.ts Outdated Show resolved Hide resolved
src/copyAs.ts Outdated Show resolved Hide resolved
shared/protocol.ts Outdated Show resolved Hide resolved
src/hexEditorProvider.ts Outdated Show resolved Hide resolved
src/hexEditorProvider.ts Outdated Show resolved Hide resolved
src/copyAs.ts Outdated Show resolved Hide resolved
src/hexEditorProvider.ts Outdated Show resolved Hide resolved
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more small comments!

package.nls.json Outdated Show resolved Hide resolved
@connor4312 connor4312 enabled auto-merge (squash) May 8, 2024 21:02
@connor4312
Copy link
Member

thanks for the PR!

@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone May 8, 2024
@connor4312 connor4312 merged commit 152a4c3 into microsoft:main May 8, 2024
3 checks passed
@joeriddles
Copy link

Has this change been released yet? I don't see mentioned of it in the CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants