Suppress sending error telemetry

microsoft · May 20, 2020 · 1caffc1 · 1caffc1
1 parent f087ffa
commit 1caffc1
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 17 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -308,12 +308,12 @@
     "ssh2": "^0.6.1",
     "validator": "^12.2.0",
     "vscode-express": "^1.0.1",
-    "vscode-extension-telemetry": "^0.1.0",
+    "vscode-extension-telemetry": "^0.1.6",
     "vscode-iot-device-cube-sdk": "^0.1.1",
     "winreg": "^1.2.3"
   },
   "extensionDependencies": [
     "vsciot-vscode.azure-iot-toolkit",
     "vsciot-vscode.vscode-iot-device-cube"
   ]
-}
+}
diff --git a/src/extension.ts b/src/extension.ts
@@ -187,7 +187,7 @@ function initDigitalTwinCommand(
         try {
           return await callback(...args);
         } catch (error) {
-          telemetryContext.properties.error = error.name;
+          telemetryContext.properties.errorType = error.name;
           telemetryContext.properties.errorMessage = error.message;
           if (error instanceof UserCancelledError) {
             telemetryContext.properties.result = TelemetryResult.Cancelled;

diff --git a/src/telemetry.ts b/src/telemetry.ts
@@ -51,7 +51,7 @@ export class TelemetryWorker {
       console.log("Unable to initialize telemetry, please make sure AIKey is set in package.json");
       return;
     }
-    this._reporter = new TelemetryReporter(packageInfo.name, packageInfo.version, packageInfo.aiKey);
+    this._reporter = new TelemetryReporter(packageInfo.name, packageInfo.version, packageInfo.aiKey, true);
     this._isInternal = TelemetryWorker.isInternalUser();
   }
 
@@ -97,7 +97,13 @@ export class TelemetryWorker {
     if (!telemetryContext) {
       telemetryContext = this.createContext();
     }
-    this._reporter.sendTelemetryEvent(eventName, telemetryContext.properties, telemetryContext.measurements);
+    if (telemetryContext.properties.result === TelemetryResult.Succeeded) {
+      this._reporter.sendTelemetryEvent(eventName, telemetryContext.properties, telemetryContext.measurements);
+    } else {
+      this._reporter.sendTelemetryErrorEvent(eventName, telemetryContext.properties, telemetryContext.measurements, [
+        "errorMessage"
+      ]);
+    }
   }
 
   /**