Skip to content
This repository has been archived by the owner on Apr 23, 2022. It is now read-only.

Suppress sending error telemetry #967

Merged
merged 2 commits into from
May 20, 2020
Merged

Suppress sending error telemetry #967

merged 2 commits into from
May 20, 2020

Conversation

hellyzh
Copy link
Collaborator

@hellyzh hellyzh commented May 20, 2020

  1. update dependency "vscode-extension-telemetry" to version 0.1.6
  2. set firstParty = true for TelemetryReporter.
  3. use sendTelemetryErrorEvent to suppress sending error telemetry.
  4. update property name of error.name from error to errorType for initDigitalTwinCommand.

IvanJobs
IvanJobs approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@IvanJobs IvanJobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my perspective.

@hellyzh hellyzh merged commit c7dc8f8 into develop May 20, 2020
@hellyzh hellyzh deleted the telemetry_update branch May 20, 2020 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IvanJobs IvanJobs IvanJobs approved these changes

@eriolchan eriolchan Awaiting requested review from eriolchan

@dilin-MS dilin-MS Awaiting requested review from dilin-MS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hellyzh @IvanJobs