Add isort.check setting
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luabud
reviewed
Oct 18, 2022
package.nls.json
Outdated
| @@ -8,6 +8,7 @@ | |||
| "settings.logLevel.off.description": "Most logging is turned off, any information that is always logged might still be shown.", | |||
| "settings.logLevel.warn.description": "Includes all messages in the error category and any additional warnings.", | |||
| "settings.args.description": "Arguments passed in. Each argument is a separate string in the array.", | |||
| "settings.check.description": "Runs `isort` in check mode, and reports import sort issues.", | |||
There was a problem hiding this comment.
just to make sure I understand it correctly: check will control whether the "imports are not correctly sorted" warning, is that correct?
Maybe something like "Controls whether to run isort and report import sort issues"?
There was a problem hiding this comment.
That is correct, this is for showing the error/warning that imports are not sorted. I will update the text.
karthiknadig
commented
Oct 19, 2022
karrtikr
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes microsoft/vscode-python#20029