Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pydantic crash on Python 3.11 #130

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 24, 2022

The fix pins pydantic to latest version, by overriding the requirements.txt generated by pip tools. This is because the currently pygls bounds on pydantic version is too restrictive.

closes #97

@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Oct 24, 2022
@karthiknadig karthiknadig self-assigned this Oct 24, 2022
@karthiknadig karthiknadig changed the title fix for pydantic crash on 3.11 Fix for pydantic crash on 3.11 Oct 24, 2022
@karthiknadig karthiknadig marked this pull request as ready for review October 24, 2022 23:16
@karthiknadig karthiknadig changed the title Fix for pydantic crash on 3.11 Fix for pydantic crash on Python 3.11 Oct 24, 2022
@karthiknadig karthiknadig merged commit b41ff6e into microsoft:main Oct 25, 2022
@karthiknadig karthiknadig deleted the fix-py11 branch October 25, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isort formatter server crashes on 3.11
2 participants