Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt extension for no reload on install #531

Closed
sandy081 opened this issue Feb 12, 2019 · 1 comment
Closed

Adopt extension for no reload on install #531

sandy081 opened this issue Feb 12, 2019 · 1 comment

Comments

@sandy081
Copy link
Member

Hi, I am a developer from VS Code and in the last release 1.31, we added a new feature - no reload is required on installing an extension - https://code.visualstudio.com/updates/v1_31#_no-reload-on-install

But there are some exceptions to it as mentioned in the doc. If the extension is contributing to external contribution points, then the extension requires reload after installing. Hence, we added a new listener API for the owners of the external contribution point to listen to extension addition/removal and can update its state - https://code.visualstudio.com/updates/v1_31#_extensions-change-event.

Our plan is to give extensions one milestone/month for adopting to the above API and make the other extensions consuming their contribution points ready for no reload. It means that from next release, above exception will be removed and all extensions are added to VS Code window immediately after installation and no reload is shown.

We scanned the extensions in the marketplace and found out that this extension uses an external contribution point javaExtensions and requires reload on install.
Found out that https://github.com/redhat-developer/vscode-java extension owns this contribution point. I have already filed an issue against that extension redhat-developer/vscode-java#794 for adoption. Filing the issue also here as this extension is impacted and can use other issue for follow up.

Thanks

@jdneo jdneo closed this as completed May 16, 2019
@jdneo jdneo reopened this May 16, 2019
@testforstephen
Copy link
Contributor

Currently all Java extensions use reloading to keep the state consistent, no plan to change this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants