Add menus to VARIABLES view to customize the display styles #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jdneo
reviewed
Apr 21, 2021
src/variableMenu.ts
Outdated
| function updateContextKeys() { | ||
| const debugSettingsRoot: vscode.WorkspaceConfiguration = vscode.workspace.getConfiguration("java.debug.settings"); | ||
| if (debugSettingsRoot) { | ||
| vscode.commands.executeCommand("setContext", "java.debug.showHex", debugSettingsRoot.showHex ? "on" : "off"); |
There was a problem hiding this comment.
Will you consider to align with the context key format used in vscode java? https://github.com/redhat-developer/vscode-java/blob/master/package.json#L996
[extension]:[key]
Leave the choice to you since it's a personal preference
There was a problem hiding this comment.
nice, suggestions accepted.
testforstephen
force-pushed
the
jinbo_variableMenus
branch
from
ad0d3c8
to
f478d25
Compare
jdneo
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this requires microsoft/java-debug#369