-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt workspaceTrust in package.json #988
Conversation
part of microsoft/vscode-java-pack#593 |
package.json
Outdated
@@ -7,6 +7,11 @@ | |||
"preview": true, | |||
"aiKey": "67d4461e-ccba-418e-8082-1bd0acfe8516", | |||
"icon": "logo.png", | |||
"enableProposedApi": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, VS Code would prevent an extension with enableProposedApi tag from being released to marketplace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://code.visualstudio.com/updates/v1_31#_proposed-extension-apis
But i saw python extension added this tag. Not sure how they did that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But i saw python extension added this tag
Yes, I checked python extension downloaded from marketplace, and it's in package.json. I'm going to have a try and I'll let you know whether I can sucsessfully upload the extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that you cannot publish an extension that uses a proposed API. We may likely make breaking changes in the next release and we never want to break existing extensions
I guess it doesn't matter to add enableProposedApi: true
, as long as we don't actually use a proposed API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried. It doesn't block any feature. But in console there will be an error log, which might be confusing for users. I'll remove this line for the moment.
No description provided.