Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt workspaceTrust in package.json #988

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Conversation

Eskibear
Copy link
Member

No description provided.

@Eskibear
Copy link
Member Author

part of microsoft/vscode-java-pack#593

package.json Outdated
@@ -7,6 +7,11 @@
"preview": true,
"aiKey": "67d4461e-ccba-418e-8082-1bd0acfe8516",
"icon": "logo.png",
"enableProposedApi": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, VS Code would prevent an extension with enableProposedApi tag from being released to marketplace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://code.visualstudio.com/updates/v1_31#_proposed-extension-apis

But i saw python extension added this tag. Not sure how they did that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But i saw python extension added this tag

Yes, I checked python extension downloaded from marketplace, and it's in package.json. I'm going to have a try and I'll let you know whether I can sucsessfully upload the extension.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you cannot publish an extension that uses a proposed API. We may likely make breaking changes in the next release and we never want to break existing extensions

I guess it doesn't matter to add enableProposedApi: true, as long as we don't actually use a proposed API.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried. It doesn't block any feature. But in console there will be an error log, which might be confusing for users. I'll remove this line for the moment.

@testforstephen testforstephen merged commit 9549124 into master Apr 28, 2021
@testforstephen testforstephen deleted the workspace-trust branch April 28, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants