Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 'rename' into the view context menu #353

Merged
merged 8 commits into from Oct 20, 2020
Merged

feat: Add 'rename' into the view context menu #353

merged 8 commits into from Oct 20, 2020

Conversation

xqzlgy2
Copy link
Contributor

@xqzlgy2 xqzlgy2 commented Oct 16, 2020 •
edited

Enable User to rename package/file in context menu like below.

  • User input new file name through input box
  • If file extension not provided, use previous extension name by default, otherwise use user's input
  • Refactoring will triggered automatically by language server
  • Register key binding for rename
  • Also add delete/rename key bindings for mac

part of #207

image
image

@jdneo
Copy link
Member

jdneo commented Oct 20, 2020

@0dinD, just FYI this is the PR for rename

@jdneo jdneo added the enhancement New feature or request label Oct 20, 2020
@jdneo jdneo added this to the 0.15.0 milestone Oct 20, 2020
@jdneo jdneo merged commit ceacecb into microsoft:master Oct 20, 2020
@jdneo
Copy link
Member

jdneo commented Oct 20, 2020

Thanks @xqzlgy2!

@xqzlgy2 xqzlgy2 deleted the rename branch October 20, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xqzlgy2 @jdneo