Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the icon of exporting jar #360

Merged
merged 3 commits into from Oct 20, 2020
Merged

Update the icon of exporting jar #360

merged 3 commits into from Oct 20, 2020

Conversation

CsCherrYY
Copy link
Contributor

No description provided.

@CsCherrYY CsCherrYY requested a review from jdneo October 20, 2020 06:51
jdneo
jdneo requested changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the dependency for the vscode type definition to 1.50.0 and update the package.lock.json

@jdneo jdneo added this to the 0.15.0 milestone Oct 20, 2020
@jdneo jdneo added the UX label Oct 20, 2020
@jdneo jdneo merged commit a5df48d into master Oct 20, 2020
@jdneo
Copy link
Member

jdneo commented Oct 20, 2020

Thanks @CsCherrYY!

@jdneo jdneo deleted the cshi-icon branch October 20, 2020 07:34
@CsCherrYY CsCherrYY changed the title Upgrade the icon of export jar Upgrade the icon of exporting jar Nov 16, 2020
@CsCherrYY CsCherrYY changed the title Upgrade the icon of exporting jar Update the icon of exporting jar Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees
No one assigned
Labels
UX
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CsCherrYY @jdneo