Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance highlighting experience #270

Closed
11 of 12 tasks
Vigilans opened this issue Dec 2, 2019 · 2 comments
Closed
11 of 12 tasks

Enhance highlighting experience #270

Vigilans opened this issue Dec 2, 2019 · 2 comments

Comments

@akaroml akaroml pinned this issue Dec 3, 2019
@0dinD
Copy link

0dinD commented Nov 18, 2020

Semantic highlighting has been provided by the Java language support extension for quite some time now, and with with the improvements I made in eclipse-jdtls/eclipse.jdt.ls#1501 consistent highlighting of types has also been achieved. Shouldn't those boxes be checked now? Or is there something specific missing from the semantic highlighting? I have a couple of smaller improvements in mind that I might submit another PR about in the future, but overall I feel like the feature can be considered "done".

@Eskibear
Copy link
Member

I think we can close this issue, as "Consistent highlighting of types" is coverred by semantic highlighting. As for syntax highlighting, PR has been created into upstream repo for a long time (just no one reviews).

@Eskibear Eskibear closed this as completed Dec 7, 2020
@Eskibear Eskibear unpinned this issue Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants