Syntax highlighting is broken with array syntax #728
Comments
|
Looks like this is caused by this issue upstream: atom/language-java#172 |
|
@snjeza please keep an eye on this one. You can provide feedback on the proposed fix upstream, if it can help getting things moved forward. |
|
Also reproduced when initialized with new operator: After new keyword gets removed: |
### Description of the Change Similar to #212, it uses a two-scope pattern to distinguish `inner-class` block and `array-initializer` block. it is based on #214 to provide correct end regex for `inner-class` and `array-initializer`. #### Detailed description Conside how a syntax scope terminates: ``` new Class() <end of new expression> ^~~~~ terminate here new Class[] <end of new expression> ^~~~~ terminate here new Class() {} <end of new expression> ^~~~~ terminate here new Class[] {} <end of new expression> ^~~~~ terminate here ``` Previous new-expr grammar handles following ways of termination: * inner-class: `(?<!\\])\\s*({)`...`(})` * parens (square): `[`...`]` * parens (round): `(`...`)` * parens (square + curly): `[`...`]`...`{`...`}` The usage of `\s*` suffers from new-line and comment-in-between pattern, and this should be relaxed using a two-scope model. Besides, `inner-class` and `array-initializer` do not share same syntax (`class-body` and `code`), so they should fall in different scope. So, this PR: * Differentiate `object-new` and `array-declaration` using two different scopes. * Put `inner-class` and `array-initializer` in different scopes, with similar names. ### Alternate Designs This PR repetitively uses the end regex of new expression: ``` 'end': '(?=;|\\)|\\]|\\.|,|\\?|:|}|\\+|\\-|\\*|\\/(?!\\/|\\*)|%|!|&|\\||\\^|=)' ``` to determine when a scope terminates. It would be better if we could find a way to reduce its usage. One possible alternative is: match when inner end token reached (`)`, `]` or `}`), not the outer token that ends it (the complex end regex). But just like #214, it is hard to tell when `)` or `]` is met, whether there will be a `{}` block next to it. I (maybe) tried such silly regexes (cannot remember them correctly): * outer - `(?<=\\)`...`}`, inner: `{`...`(?=}` The problem with it: if there's no `}` after `)`, it won't ends, causing the whole `new-expr` scope won't ends. e.g. `A[] arr = new A[]{ new A(), new A() };` - the comma won't ends first `new A()` because inner scope eats until `}` is met. ### Benefits * Can correctly highlight `array-initializer` when there's any distance of spaces between ']' and '{'. * Can correctly highlight `array-initializer` when '{' is placed at new line or with a comment in between. * Introduced a new scope `array-initializer`, in correspondence with `inner-class`. * Patterns are more neat and uniform. ### Possible Drawbacks * Undetected possible regression issues. ### Applicable Issues Fix #172 Fix #199 Fix redhat-developer/vscode-java#728
|
Found that some array syntax still breaks some highlighting using
|
|
@nkibbey It has been fixed in upstream, and has been adopted in vscode-insiders. I just tried in latest vscode-insiders, and it worked. So it's expected to be shipped in the next stable release of vscode. |
|
@fbricon Vscode 1.44.2, the following snippet isn't highlighted correctly: class A {
public static void name() {
for (int i = 0; i==0;){
}
String[] aaa = new String[] {
String.class.toString(),
"aaaa",
"bbb",
};
for (int i = 0; i==0;){
}
}
}Maybe it's https://github.com/microsoft/vscode/blob/master/extensions/java/syntaxes/java.tmLanguage.json problem |
|
@Yanpas sorry I did update my previous comment. Your issue is fixed in upcoming 0.61.0, with semantic highlighting turned on:
|
[provide a description of the issue]
Environment
Steps To Reproduce
Snippet:
The text was updated successfully, but these errors were encountered: