Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBM Semeru Runtimes to Other JDKs list #1113

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

AdamBrousseau
Copy link
Contributor

Signed-off-by: Adam Brousseau adam.brousseau@ca.ibm.com

@AdamBrousseau
Copy link
Contributor Author

@Eskibear for review please.
Also see microsoft/vscode-docs#5784

I'm not sure if I need any other changes or if this is complete.
Thanks

Signed-off-by: Adam Brousseau <adam.brousseau@ca.ibm.com>
@Eskibear
Copy link
Member

@nickzhums
Copy link
Member

Hi @AdamBrousseau, thanks for submitting the PR. This is Nick and I'm the PM for VS Code Java. Feel free to ping us if you have other questions in the future.

Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep consistence with docs.

@Eskibear Eskibear merged commit b0f8d5b into microsoft:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants