Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JUnit5 parallel execution #1472

Closed
Tracked by #1157
mseele opened this issue Aug 19, 2022 · 5 comments · Fixed by #1519
Closed
Tracked by #1157

Support JUnit5 parallel execution #1472

mseele opened this issue Aug 19, 2022 · 5 comments · Fixed by #1519

Comments

@mseele
Copy link

mseele commented Aug 19, 2022

We write more and more test to be able to run in parallel. This works, but vscode sometimes does display the wrong result-status icon in front of the tests.
After a (parallel) test run, there should be a green checkbox (or red cross) next to the test name in the test view. However vscode does get confused by the parallel test run and shows only a few result icons and lot's of "not-run" icons next to the (ran) tests. Please see my attached screenshot for further details.

And feel free to reach out for more details or something I can help with this issue.

Bildschirmfoto 2022-08-19 um 11 32 01

@mseele
Copy link
Author

mseele commented Aug 19, 2022

It's even worse! Running the tests in parallel do hide failures:

Bildschirmfoto 2022-08-19 um 12 54 04

@jdneo
Copy link
Member

jdneo commented Aug 20, 2022

Thank you for the feedback. Parallel execution is not supported right now.

@jdneo jdneo changed the title Wrong result-status icons when running JUnit5 tests in parallel Support JUnit5 parallel execution Aug 20, 2022
@mseele
Copy link
Author

mseele commented Aug 22, 2022

Thank you for the clarification. Is there a timeline to implement this feature or anything I can help with?

@jdneo
Copy link
Member

jdneo commented Aug 23, 2022

Sorry no definite timeline yet. But contributions are welcome.

I think the problem happens at

if (item.id !== this.currentItem?.id) {

The current logic assumes that each time only one test item is treated, which is wrong.

fladdimir added a commit to fladdimir/vscode-java-test that referenced this issue Jan 11, 2023
fladdimir added a commit to fladdimir/vscode-java-test that referenced this issue Jan 11, 2023
fladdimir added a commit to fladdimir/vscode-java-test that referenced this issue Jan 11, 2023
fladdimir added a commit to fladdimir/vscode-java-test that referenced this issue Jan 11, 2023
fladdimir added a commit to fladdimir/vscode-java-test that referenced this issue Jan 11, 2023
@fladdimir
Copy link
Contributor

@mseele its been some time since there was activity on this issue, so I assumed you did not have time to work on it for now. please feel free to have a look at the created PR, suggest improvements, and see whether this also fits your use-case.

fladdimir added a commit to fladdimir/vscode-java-test that referenced this issue Jan 14, 2023
fladdimir added a commit to fladdimir/vscode-java-test that referenced this issue Jan 19, 2023
jdneo added a commit that referenced this issue Jan 24, 2023
Co-authored-by: Sheng Chen <sheche@microsoft.com>
@jdneo jdneo added this to the 0.38.0 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants