Skip to content

Commit

Permalink
fix: child processes from extension host not getting spawned during d…
Browse files Browse the repository at this point in the history
…ebug (#1767)
  • Loading branch information
connor4312 committed Jul 31, 2023
1 parent 5e9e723 commit 027ae05
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

This changelog records changes to stable releases since 1.50.2. "TBA" changes here may be available in the [nightly release](https://github.com/microsoft/vscode-js-debug/#nightly-extension) before they're in stable. Note that the minor version (`v1.X.0`) corresponds to the VS Code version js-debug is shipped in, but the patch version (`v1.50.X`) is not meaningful.

## Nightly (only)

- fix: child processes from extension host not getting spawned during debug

## v1.81 (July 2023)

- fix: child process tree not terminating on all Linux distros ([#1747](https://github.com/microsoft/vscode-js-debug/issues/1747))
Expand Down
4 changes: 3 additions & 1 deletion src/targets/node/extensionHostAttacher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,14 @@ export class ExtensionHostAttacher extends NodeAttacherBase<IExtensionHostAttach
return;
}

const vars = await this.resolveEnvironment(
let vars = await this.resolveEnvironment(
run,
new NodeBinary('node', Semver.parse(process.versions.node)),
{ openerId: targetId },
);

vars = vars.update('ELECTRON_RUN_AS_NODE', null);

for (let retries = 0; retries < 200; retries++) {
const result = await cdp.Runtime.evaluate({
contextId: 1,
Expand Down

0 comments on commit 027ae05

Please sign in to comment.