Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make timeout for evaluation on hover configurable #1242

Closed
timvahlbrock opened this issue Apr 20, 2022 · 1 comment · Fixed by #1243
Closed

Make timeout for evaluation on hover configurable #1242

timvahlbrock opened this issue Apr 20, 2022 · 1 comment · Fixed by #1243
Assignees
@connor4312
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2022

Comments

@timvahlbrock
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, value evaluation for hovering is timed out after 500ms. If CDP communication plus evaluation within the browser takes longer than 500ms, no hover value is shown.

Describe the feature you'd like
The situation can be resolved in one of the following ways.

  • Increase the timeout
  • Remove the timeout all together
  • Make the timeout configurable within launch or workspace options

Furthermore, VS Code hovering delays the creation of the debug hover by one second to make the UI less hectic (see #2309). Evaluation could be started as soon as hovering is detected, so that the time required for evaluation falls within the UI delay. But this would likely require changes in VS Code itself.
@timvahlbrock timvahlbrock added the feature-request Request for new features or functionality label Apr 20, 2022
@connor4312
Copy link
Member

Sure, PR's welcome. I think raising it is probably fine, but a setting is ok too.

@connor4312 connor4312 added the good first issue Issues identified as good for first-time contributors label Apr 20, 2022
@timvahlbrock timvahlbrock mentioned this issue Apr 20, 2022
Merged
connor4312 pushed a commit that referenced this issue Apr 21, 2022
@timvahlbrock
feat: make hover evaluation timeout configurable (#1243)
8e87a53 
Fixes #1242
@connor4312 connor4312 added this to the April 2022 milestone Apr 21, 2022
@joyceerhl joyceerhl added the verification-needed Verification of issue is requested label Apr 26, 2022
@connor4312 connor4312 added the verified Verification succeeded label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

Successfully merging a pull request may close this issue.

feat: make hover evaluation timeout configurable
3 participants
@connor4312 @timvahlbrock @joyceerhl