-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugging javascript with Oh My Posh in WSL2 produces a weird debugger state and no output #1642
Comments
Is there anything we can do here @Tyriar @meganrogge? |
a lot going on here
I think @connor4312 might know more |
That's fine and valid. The issue here seems solely that the text is injected before the shell(?) is ready and the ignored. Not sure whether that's entirely on us or not. Here's the code where the terminal is started and program is written vscode-js-debug/src/targets/node/terminalNodeLauncher.ts Lines 132 to 146 in bebebd6
@meganrogge do you think we should await the |
Would this mean that any sufficiently large/slow |
Yes @connor4312 I think that would fix it. We do that in debug before sending text |
Ah, I see, thanks. It's quite unfortunate that we have that one second pause if we need to |
Oh, I don't think you'll need to do that. I would think just the |
My particular
|
* fix: terminal launches sometimes sending commands too soon Fixes #1642 * address pr comments
Verified with a code review, but @bnm12 pls let us know if this now works for you without the workaround you mentioned above |
Type: Bug
Using WSL 2 (Ubuntu 22.04.2)
When I have the Oh My Posh theme in my .bashrc file and lunch a debug task that starts a npm task in the javascript debugging terminal it seems like the task executes before Oh My Posh does and gets cut off. The debugger starts, but no output prints to the terminal.
Also no breakpoints get hit and the vs-code debug call stack doesn't populate.
Re-running the command that prints to the terminal manually after it's initalized (same terminal window) works as expected
Initial state
![image](https://user-images.githubusercontent.com/2268946/220912536-d99d49e2-0f50-40c8-9fdb-18af0d572329.png)
Re-running command manually
![image](https://user-images.githubusercontent.com/2268946/220913050-33c053f1-37ba-465c-badc-e0518ede4c2e.png)
My launch configuration is:
VS Code version: Code 1.75.1 (441438abd1ac652551dbe4d408dfcec8a499b8bf, 2023-02-08T21:32:34.589Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes
Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Extensions (44)
(3 theme extensions excluded)
A/B Experiments
The text was updated successfully, but these errors were encountered: