Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger starts in non JavaScript Debug Terminal and crashes #1660

Closed
lazpavel opened this issue Apr 14, 2023 · 6 comments · Fixed by microsoft/vscode#184764
Closed

Debugger starts in non JavaScript Debug Terminal and crashes #1660

lazpavel opened this issue Apr 14, 2023 · 6 comments · Fixed by microsoft/vscode#184764
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@lazpavel
Copy link

image

@connor4312
Copy link
Member

Can you please share the result of the following two commands?

  • echo $NODE_OPTIONS
  • echo $VSCODE_INSPECTOR_OPTIONS

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Apr 14, 2023
@lazpavel
Copy link
Author

Sure,

echo $NODE_OPTIONS

--require "/Users/lazpavel/Library/Application Support/Code/User/workspaceStorage/74062fa4b9e1d9cb9e25d967262b40f0/ms-vscode.js-debug/bootloader.js"

echo $VSCODE_INSPECTOR_OPTIONS

:::{"inspectorIpc":"/var/folders/cs/srz6zwz14kgfh438vb669cz40000gs/T/node-cdp.89345-1b072c56-7.sock.deferred","deferredMode":true,"waitForDebugger":"","execPath":"/Users/lazpavel/.nvm/versions/node/v16.17.0/bin/node","onlyEntrypoint":false,"autoAttachMode":"always"}

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jun 9, 2023
@connor4312 connor4312 self-assigned this Jun 9, 2023
@connor4312 connor4312 added this to the June 2023 milestone Jun 9, 2023
connor4312 added a commit to microsoft/vscode that referenced this issue Jun 9, 2023
connor4312 added a commit to microsoft/vscode that referenced this issue Jun 9, 2023
connor4312 added a commit to microsoft/vscode that referenced this issue Jun 9, 2023
@roblourens roblourens added the author-verification-requested Issues potentially verifiable by issue author label Jun 28, 2023
@roblourens
Copy link
Member

roblourens commented Jun 28, 2023

@lazpavel is this working for you in the latest Insiders build? @connor4312 what happened here, how do I test it?

@roblourens roblourens added the verification-steps-needed Steps to verify are needed for verification label Jun 28, 2023
@connor4312
Copy link
Member

connor4312 commented Jun 28, 2023

I hypothesize that the tmpdir location rotated and that the socket path that was initially set was no longer valid. I don't know whether a change to the tmpdir can be forced. I adding some dummy code in OSS to 'corrupt' the ipcAddress in debug-auto-launch when read from storage and making sure it gets re-set afterwards.

https://github.com/microsoft/vscode/blob/68dc2206ef350dba57f50bcdb2a6c8a3719cfc96/extensions/debug-auto-launch/src/extension.ts#L375

@connor4312 connor4312 removed the verification-steps-needed Steps to verify are needed for verification label Jun 28, 2023
@roblourens
Copy link
Member

I'm not really sure what to do with that, but I think the code change looks straightforward. I'll mark it as verified, if you think I should try running the scenario then maybe you can share your code change to OSS

@roblourens roblourens added the verified Verification succeeded label Jun 29, 2023
@lazpavel
Copy link
Author

I don't think this issue is completely resolved, it still happens if I have more than one instance of vscode running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants