Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback should optimistically pick a new hostname when it falls back #1694

Closed
connor4312 opened this issue May 3, 2023 · 1 comment · Fixed by #1695
Closed

Fallback should optimistically pick a new hostname when it falls back #1694

connor4312 opened this issue May 3, 2023 · 1 comment · Fixed by #1695
Assignees
Labels
debt Code quality issues
Milestone

Comments

@connor4312
Copy link
Member

          @roblourens it is working kind of, when I add the host entry ::1 to the host file.
$ ping localhost
PING localhost(ipv6-localhost (::1)) 56 data bytes
64 bytes from ipv6-localhost (::1): icmp_seq=1 ttl=64 time=0.024 ms

However when I refresh or hard-refresh sometimes the breakpoints don't get it, and sometime it will get it. Also I've noticed things run much slower now to the point I wouldn't want to use this debugger.

So to check, I commented out host entry ::1 in my hosts file and the debugger works all the time and it really responsive. When I do a refresh the breakpoint gets hit instantly.

$ ping localhost
PING localhost (127.0.0.1) 56(84) bytes of data.
64 bytes from localhost (127.0.0.1): icmp_seq=1 ttl=64 time=0.162 ms

Originally posted by @rajinder-yadav in microsoft/vscode#167353 (comment)

@connor4312 connor4312 self-assigned this May 3, 2023
@connor4312 connor4312 added this to the May 2023 milestone May 3, 2023
@connor4312 connor4312 added the debt Code quality issues label May 3, 2023
connor4312 added a commit that referenced this issue May 3, 2023
…s back (#1695)

* perf: fallback should optimistically pick a new hostname when it falls back
Fixes #1694

* update to fix tests
@connor4312
Copy link
Member Author

@rajinder-yadav you should see better performance in the forthcoming nightly build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues
Projects
None yet
1 participant