[Bug] RN application crashes from VSCode 1.83.0 #1837

EzioLi01 · 2023-10-07T06:16:29Z

Hey @connor4312, we found that react-native application will be crashed when update vscode to 1.83.0, checked this issue is occurring from js-debug v1.83.0 prod and v2023.9.1317 nightly. microsoft/vscode-react-native#2052

Here is the screen record and js-debug trace log, could you please help to check if we have any updates may cause this issue? Thank you!

Repro step:

Install react-native by npm i -g react-native
Create template app by npx react-native init sampleApp
Install react-native-tools in vscode
Run npm run android to run app in emulator
Add Attach to Hermes application - Experimental in launch.json with default options
Attach debugger, add breakpoint and trigger it

Record:

Trace:
vscode-debugadapter-5f2fdf71.json.gz

The text was updated successfully, but these errors were encountered:

connor4312 · 2023-10-07T22:51:47Z

It seems to crash when this function is called on various objects in the scope, which is used to generate the previews seen in the Variables view. I'm guessing this is some kind of native crash; more info about what's going wrong would help. A native crash would not really be an issue in the debugger but we can see if a workaround is available

vscode-js-debug/src/adapter/templates/getStringyProps.ts

Lines 25 to 76 in eb545fa

    
           /** 
        
            * Gets a mapping of property names with a custom `.toString()` method 
        
            * to their string representations. 
        
            */ 
        
           export const getStringyProps = templateFunction(function ( 
        
             this: unknown, 
        
             maxLength: number, 
        
             customToString: (defaultRepr: string) => unknown, 
        
           ) { 
        
             const out: Record<string, string> = {}; 
        
             const defaultPlaceholder = '<<default preview>>'; 
        
             if (typeof this !== 'object' || !this) { 
        
               return out; 
        
             } 
        
             for (const [key, value] of Object.entries(this)) { 
        
               if (customToString) { 
        
                 try { 
        
                   const repr = customToString.call(value, defaultPlaceholder); 
        
                   if (repr !== defaultPlaceholder) { 
        
                     out[key] = String(repr); 
        
                     continue; 
        
                   } 
        
                 } catch (e) { 
        
                   out[key] = `<<indescribable>>${JSON.stringify([String(e), key])}`; 
        
                   continue; 
        
                 } 
        
               } 
        
               if (typeof value === 'object' && value) { 
        
                 let str: string | undefined; 
        
                 for (const sym of runtimeArgs[0]) { 
        
                   try { 
        
                     str = value[sym](); 
        
                     break; 
        
                   } catch { 
        
                     // ignored 
        
                   } 
        
                 } 
        
                 if (!str && !String(value.toString).includes('[native code]')) { 
        
                   str = String(value); 
        
                 } 
        
                 if (str && !str.startsWith('[object ')) { 
        
                   out[key] = str.length >= maxLength ? str.slice(0, maxLength) + '…' : str; 
        
                 } 
        
               } 
        
             } 
        
             return out; 
        
           });

EzioLi01 · 2023-10-08T00:46:51Z

Thanks @connor4312 sharing information, I will try to debug on this. Also adding some log in DevTools console.

console.ts:137 [Extension Host] TypeError: Cannot read properties of undefined (reading 'map')
	at c:\Users\v-yukl\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\ms-vscode.js-debug\src\extension.js:103:6964
	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
	at async Promise.all (index 0)
	at async mn.getBreakpointLocations (c:\Users\v-yukl\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\ms-vscode.js-debug\src\extension.js:103:7197)
	at async c:\Users\v-yukl\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\ms-vscode.js-debug\src\extension.js:159:4398
	at async Zl._onMessage (c:\Users\v-yukl\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\ms-vscode.js-debug\src\extension.js:71:4859)
$ @ console.ts:137
$logExtensionHostMessage @ mainThreadConsole.ts:39
S @ rpcProtocol.ts:456
Q @ rpcProtocol.ts:441
M @ rpcProtocol.ts:371
L @ rpcProtocol.ts:297
(anonymous) @ rpcProtocol.ts:161
z @ event.ts:1138
fire @ event.ts:1169
fire @ ipc.net.ts:650
Y.onmessage @ localProcessExtensionHost.ts:581

ERR Invalid debug adapter: Error: Invalid debug adapter
    at v.m (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1543:95)
    at v.$acceptDAError (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1542:7624)
    at m.S (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1551:18856)
    at m.Q (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1551:18622)
    at m.M (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1551:17715)
    at m.L (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1551:16794)
    at u.value (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1551:15597)
    at c.z (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)
    at c.fire (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)
    at r.fire (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:616:14393)
    at Y.onmessage (vscode-file://vscode-app/c:/Users/v-yukl/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1652:1077)

benjaminbi · 2023-10-08T11:21:16Z

adding some info
the issue seems occur since 676e7e7. The previous commit (72c0276) works well on my machine.

EzioLi01 · 2023-10-09T08:33:42Z

@connor4312, I think this might be the root cause. When we attach debugger to RN application, js-debug will get breakpoint location in function:

vscode-js-debug/src/adapter/breakpoints.ts

Line 313 in eb545fa

public async getBreakpointLocations(

In line 373:

vscode-js-debug/src/adapter/breakpoints.ts

Lines 370 to 397 in eb545fa

todo.push(

thread

.cdp()

.Debugger.getPossibleBreakpoints({

restrictToFunction: false,

start: { scriptId, ...lsrc.offsetSourceToScript(base1To0(start)) },

end: { scriptId, ...lsrc.offsetSourceToScript(base1To0(end)) },

})

.then(r => {

if (!r) {

return;

}

// Map the locations from CDP back to their original source positions.

// Discard any that map outside of the source we're interested in,

// which is possible (e.g. if a section of code from one source is

// inlined amongst the range we request).

return Promise.all(

r.locations.map(async breakLocation => {

const { lineNumber, columnNumber = 0 } = breakLocation;

const uiLocations = await this._sourceContainer.currentSiblingUiLocations({

source: lsrc,

...lsrc.offsetScriptToSource(base0To1({ lineNumber, columnNumber })),

});

result.push({ breakLocation, uiLocations });

}),

);

the function Debugger.getPossibleBreakpoints got the empty breakpoint object r={}, so the exception will be throwed since r.locations=undefined that cannot call function map.

But I have checked source url(source.js.zip), strangely the breakpoint start and end location seems be getting correctly in:

vscode-js-debug/src/adapter/breakpoints.ts

Lines 321 to 332 in eb545fa

const [startLocations, endLocations] = await Promise.all([

this._sourceContainer.currentSiblingUiLocations({

source,

lineNumber: start1.lineNumber,

columnNumber: start1.columnNumber,

}),

this._sourceContainer.currentSiblingUiLocations({

source,

lineNumber: end1.lineNumber,

columnNumber: end1.columnNumber,

}),

]);

I'm not familiar with CDP api, @connor4312 could you please guide me on this? Any info you needed please let me know. I will keep on investigating this issue.

BTW, found an issue in RN Hermes engine repo, I'm not sure if it's related to this: facebook/hermes#1087

connor4312 · 2023-10-09T16:10:33Z

I put in a fix for that, though I don't think that would be the cause of the crash. Available in the next nightly build.

For #1837

EzioLi01 · 2023-10-10T01:57:17Z

Thank you @connor4312 for the quick response, it not the reason of crashing, but resolved an unexpected error in console log. I will continue looking into this. Thank you!

EzioLi01 · 2023-10-10T05:12:40Z

Hey @connor4312, it should be the correct location. In new method getEnhancedName(), app will crash on callFunctionOn:

vscode-js-debug/src/adapter/stackTrace.ts

Lines 319 to 323 in 2bf8458

const ret = await thread.cdp().Runtime.callFunctionOn({

functionDeclaration: getToStringIfCustom.decl('64', 'null'),

objectId: callFrame.this.objectId,

returnByValue: true,

});

And I do some testing on my project, seems this crash can be fixed on react-native-tools by updating callFunctionOn event. I will try on this firstly. Please keep this issue opening, and I will close it if I can fix it on my project.

Thanks again for your positive help!

EzioLi01 · 2023-10-11T06:50:45Z

Close this issue, since it's resolved in RNT project.

EzioLi01 added the bug Issue identified by VS Code Team member as probable bug label Oct 7, 2023

EzioLi01 assigned connor4312 Oct 7, 2023

connor4312 added the info-needed Issue requires more information from poster label Oct 7, 2023

connor4312 added a commit that referenced this issue Oct 9, 2023

fix: handle getPossibleBreakpoints response from hermes

a81f586

For #1837

connor4312 mentioned this issue Oct 9, 2023

fix: handle getPossibleBreakpoints response from hermes #1841

Merged

connor4312 added a commit that referenced this issue Oct 9, 2023

fix: handle getPossibleBreakpoints response from hermes (#1841)

2bf8458

For #1837

EzioLi01 closed this as completed Oct 11, 2023

ghry5 mentioned this issue Oct 20, 2023

[dev client] Debugger crashes app on breakpoint hit expo/vscode-expo#231

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] RN application crashes from VSCode 1.83.0 #1837

[Bug] RN application crashes from VSCode 1.83.0 #1837

EzioLi01 commented Oct 7, 2023 •

edited

Loading

connor4312 commented Oct 7, 2023

EzioLi01 commented Oct 8, 2023

benjaminbi commented Oct 8, 2023 •

edited

Loading

EzioLi01 commented Oct 9, 2023 •

edited

Loading

connor4312 commented Oct 9, 2023

EzioLi01 commented Oct 10, 2023 •

edited

Loading

EzioLi01 commented Oct 10, 2023

EzioLi01 commented Oct 11, 2023

[Bug] RN application crashes from VSCode 1.83.0 #1837

[Bug] RN application crashes from VSCode 1.83.0 #1837

Comments

EzioLi01 commented Oct 7, 2023 • edited Loading

connor4312 commented Oct 7, 2023

EzioLi01 commented Oct 8, 2023

benjaminbi commented Oct 8, 2023 • edited Loading

EzioLi01 commented Oct 9, 2023 • edited Loading

connor4312 commented Oct 9, 2023

EzioLi01 commented Oct 10, 2023 • edited Loading

EzioLi01 commented Oct 10, 2023

EzioLi01 commented Oct 11, 2023

EzioLi01 commented Oct 7, 2023 •

edited

Loading

benjaminbi commented Oct 8, 2023 •

edited

Loading

EzioLi01 commented Oct 9, 2023 •

edited

Loading

EzioLi01 commented Oct 10, 2023 •

edited

Loading