Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension does not parse resolveSourceMapLocations regex correctly #1944

Closed
antoniozh opened this issue Feb 20, 2024 · 7 comments · Fixed by #1983
Closed

Extension does not parse resolveSourceMapLocations regex correctly #1944

antoniozh opened this issue Feb 20, 2024 · 7 comments · Fixed by #1983
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@antoniozh
Copy link

antoniozh commented Feb 20, 2024

Describe the bug
In my launch.json, I included every source map file with the following regular expression:
"${workspaceFolder}/**"
This should include everything. However, a few days ago my breakpoints were not bound correctly. After some troubleshooting, I found that manually adding the directory containing the source map files to the resolveSourceMapLocations field fixes my issue again.
I therefore suspect that the first regular expression did not work despite matching everything.

To Reproduce
Steps to reproduce the behavior:

  1. Clone this example repository
  2. Compile and run the debugger with a breakpoint set in main.ts
  3. Check if the breakpoint is set correctly and then add "${workspaceFolder}/build/*.map" to the resolveSourceMapLocations field.
  4. Check the breakpoint again

VS Code Version: 1.86.2
Extension version: v1.86.1

Additional context
Add any other context about the problem here.

@antoniozh antoniozh added the bug Issue identified by VS Code Team member as probable bug label Feb 20, 2024
@connor4312
Copy link
Member

This works for me using your repo -- if it's still an issue, can you please collect a log file using the instructions in the issue template:

If you're able to, add "trace": true to your launch.json and reproduce the issue. The location of the log file on your disk will be written to the Debug Console. Share that with us.

⚠️ This log file will not contain source code, but will contain file paths. You can drop it into https://microsoft.github.io/vscode-pwa-analyzer/index.html to see what it contains. If you'd rather not share the log publicly, you can email it to connor@xbox.com

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Mar 1, 2024
@antoniozh
Copy link
Author

Hello, I just sent you a mail, thank you!

@connor4312 connor4312 removed the info-needed Issue requires more information from poster label Apr 1, 2024
@connor4312
Copy link
Member

Thanks, should be fixed in the next nightly build https://github.com/microsoft/vscode-js-debug#nightly-extension

@connor4312 connor4312 added this to the April 2024 milestone Apr 1, 2024
@eleanorjboyd eleanorjboyd added the verification-steps-needed Steps to verify are needed for verification label Apr 23, 2024
@eleanorjboyd
Copy link
Member

Hello @antoniozh, are you able to verify if this fix on vscode insiders has resolved your problem?

@antoniozh
Copy link
Author

I will report back once I install vscode insiders

@connor4312
Copy link
Member

Please use the nightly build, which works on either stable or Insiders: https://github.com/microsoft/vscode-js-debug#nightly-extension

@antoniozh
Copy link
Author

Good morning, the nightly works for me and the stable version is still broken, so I'm assuming you fixed my issue. Thank you!

@connor4312 connor4312 added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants