Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test status #44

Closed
1 of 15 tasks
roblourens opened this issue Oct 23, 2019 · 0 comments
Closed
1 of 15 tasks

Integration test status #44

roblourens opened this issue Oct 23, 2019 · 0 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Oct 23, 2019

The current status of failing Chrome integration tests ported from the old codebase

Had to run some of these individually to get a clean run, since Chrome doesn't always shut down.

  • "Attach without specifying a url"
    • Attach request
  • 2 adapter.test.ts case sensitivity tests
    • Need to patch dc.launchRequest same as dc.launch
  • "should stop on debugger statement"
    • "debugger" pause reason
  • "Unknown request should produce error"
    • Timeout, looks for certain error response
  • "Hit breakpoint on JavaScript when source map is invalid"
    • Crashes adapter, exception thrown from source-map
  • 2 "Should launch successfully on port 0" tests
    • Not hooked up properly (?)
  • "Unusual source-maps"
    • Column off by 1
  • "Should stop on a breakpoint in an in-line script"
    • Stack frame format (?)
  • "No unhandled exceptions when we parse invalid JavaScript code"
    • Looks for certain error output
  • 3 "loaded sources" tests
    • "debugger" pause reason
    • And late "continue" events (DA sends "continue" after disconnect which Pinezorro will not like)
  • 4 "stack traces" tests
    • Some difference in formatting
  • Some others previously disabled as failing
  • Many hit condition breakpoints
    • Not implemented
  • Break on load related tests
    • Needs investigation
  • React framework tests
    • Needs investigation

Also only Chrome tests have been ported. There are a smaller number of node tests that I need to port as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants