Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test reliability + make them runnable on PR builds #28

Closed
connor4312 opened this issue Oct 16, 2019 · 0 comments · Fixed by #110
Closed

Improve test reliability + make them runnable on PR builds #28

connor4312 opened this issue Oct 16, 2019 · 0 comments · Fixed by #110
Labels
debt Code quality issues
Milestone
Self-Host

Comments

@connor4312
Copy link
Member

connor4312 commented Oct 16, 2019 •
edited
Loading

Some tests like to fail or timeout with a fresh clone, seemingly randomly.

Related: #44
connor4312 added a commit that referenced this issue Oct 17, 2019
@connor4312
feat: complete updating options to new format
b9a303e 
Tests are somewhat flakey (#28) but them seem to behave just as well as before, and everything appears to work nicely.
@connor4312 connor4312 mentioned this issue Oct 17, 2019
Merged
@roblourens roblourens mentioned this issue Oct 25, 2019
Closed
8 tasks
@connor4312 connor4312 added this to the v0.0.0 milestone Nov 4, 2019
@connor4312 connor4312 changed the title Improve test reliability Improve test reliability + make them runnable on PR builds Nov 4, 2019
@connor4312 connor4312 added the debt Code quality issues label Nov 5, 2019
@roblourens roblourens mentioned this issue Nov 20, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt Code quality issues
Projects
None yet
Milestone
Self-Host
Development

Successfully merging a pull request may close this issue.

Enable tests in CI microsoft/vscode-js-debug
1 participant
@connor4312