Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Unknown session id: <session-id> while processing: Inspector.targetReloadedAfterCrash #486

Closed
digeff opened this issue May 26, 2020 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded vs-p1 P1 issue for the Visual Studio proper team
Milestone

Comments

@digeff
Copy link
Contributor

digeff commented May 26, 2020

We got telemetry that the debug adapter is seeing a lot of this error:

Error: Unknown session id: <session-id> while processing: Inspector.targetReloadedAfterCrash
    at t.default._onMessage (connection.js:47:19)
    at call (connection.js:19:61)
    at t.EventEmitter.fire (events.js:36:27)
    at T.call (webSocketTransport.js:21:33)
    at T.r (event-target.js:120:16)
    at T.emit (events.js:210:5)
    at e.exports.R (websocket.js:801:20)
    at e.exports.emit (events.js:210:5)
    at e.exports.dataMessage (receiver.js:436:14)
    at e.exports.getData (receiver.js:366:17)

This also happens while processing these other events, and some request responses too:

  • Debugger.scriptParsed
  • Mono.runtimeReady
  • Runtime.consoleAPICalled
  • Inspector.targetCrashed
  • Inspector.detached

Can this be causing a detrimental experience to the users?

@digeff digeff added vs-p2 P2 issue for the Visual Studio proper team vs-p1 P1 issue for the Visual Studio proper team and removed vs-p2 P2 issue for the Visual Studio proper team labels May 26, 2020
@digeff
Copy link
Contributor Author

digeff commented Jun 1, 2020

@connor4312 A lot of our users are hitting this issue. Raising to vs-p1

@connor4312 connor4312 added this to the June 2020 milestone Jun 8, 2020
@connor4312
Copy link
Member

Found one big case I was hitting locally -- if the user manually detached from a target, we didn't tell Chrome about that, so were still getting messages from a tab that we didn't care about.

@digeff
Copy link
Contributor Author

digeff commented Jun 9, 2020

Awesome! :)

@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Jul 1, 2020
@connor4312 connor4312 modified the milestones: June 2020, July 2020 Jul 1, 2020
@connor4312 connor4312 modified the milestones: July 2020, August 2020 Aug 6, 2020
@connor4312
Copy link
Member

@digeff / @EricCornelson do you still see this coming up in your telemetry since my initial fix above?

@connor4312
Copy link
Member

Closing and marking verified -- please let me know if this is not appropriate.

@connor4312 connor4312 added the verified Verification succeeded label Sep 3, 2020
@digeff
Copy link
Contributor Author

digeff commented Sep 4, 2020

@connor4312 Sorry for the delay. At the moment all the stack traces in telemetry are blank, so we don't know what's happening yet. We are looking into this.

@connor4312 connor4312 removed the verified Verification succeeded label Sep 4, 2020
@connor4312 connor4312 modified the milestones: August 2020, September 2020 Sep 4, 2020
@connor4312 connor4312 modified the milestones: December 2020, January 2021 Jan 8, 2021
@roblourens roblourens added the verified Verification succeeded label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded vs-p1 P1 issue for the Visual Studio proper team
Projects
None yet
Development

No branches or pull requests

3 participants