fix: improve repl/variable/completion performance for TS #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1433 There were a couple problems: - TS uses a `customDescriptionGenerator`. Previously this was being invoked on each individual property. I've merged this with the logic we added for custom `toString()` representations, so that we run it only once for an object and return a map of its properties. - TS has thousands of variables in each scope. We call `Runtime.getProperties` to get scope variables to use in completions. It seems like getProperties, which does not have any 'limit' parameter, is blocking. We still need this to do sensible completions, but now each stacktrace caches its completions instead of getting new ones on every request. With these changes, there may still be a little REPL stall on the first evaluation (until the first completions call finishes, which takes 3-5s on my macbook), but after that it should be appropriately snappy.
connor4312
force-pushed
the
fix/ts-completion-improvements
branch
from
d6e916e
to
647a933
Compare
|
Updated test fixtures to make tests happy. The issue was previously we showed the custom description in the |
connor4312
commented
Dec 9, 2022
|
|
||
| constructor( | ||
| @inject(IRenameProvider) private readonly renameProvider: IRenameProvider, | ||
| @inject(ICdpApi) private readonly cdp: Cdp.Api, | ||
| @inject(IDapApi) private readonly dap: Dap.Api, | ||
| @inject(AnyLaunchConfiguration) private readonly launchConfig: AnyLaunchConfiguration, | ||
| private readonly locationProvider: IVariableStoreLocationProvider, | ||
| ) {} | ||
| ) { | ||
| this.contextSettings = { |
There was a problem hiding this comment.
Previously we were code-genning every time we made a preview for a variable. Fortunately Acorn is pretty speedy, but we can precompute that instead easily :)
Tyriar
requested changes
Dec 9, 2022
|
flake that I need to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1433
There were a couple problems:
customDescriptionGenerator. Previously this was being invoked on each individual property. I've merged this with the logic we added for customtoString()representations, so that we run it only once for an object and return a map of its properties.Runtime.getPropertiesto get scope variables to use in completions. It seems like getProperties, which does not have any 'limit' parameter, is blocking. We still need this to do sensible completions, but now each stacktrace caches its completions instead of getting new ones on every request.With these changes, there may still be a little REPL stall on the first evaluation (until the first completions call finishes, which takes 3-5s on my macbook), but after that it should be appropriately snappy.