fix: shutdown of debug adapter being slow #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This iteration we moved to named pipes for the connection to VS Code. This exposed a race that wasn't hit for TCP connections: the destroy call for streams was being invoked on the next tick after calling transports' send(), which could be before the write happened. The result was the DAP terminated() event didn't get sent through so VS Code was just timing out the session after a second, which looked janky.
joyceerhl
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This iteration we moved to named pipes for the connection to VS Code.
This exposed a race that wasn't hit for TCP connections: the destroy
call for streams was being invoked on the next tick after calling
transports' send(), which could be before the write happened.
The result was the DAP terminated() event didn't get sent through so
VS Code was just timing out the session after a second, which looked janky.