fix: skipFiles being slow in remotes #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
commented
Jan 24, 2023
| @@ -195,7 +200,7 @@ export class ScriptSkipper { | |||
| return true; | |||
| } | |||
|
|
|||
| return this._testSkipAuthored(this._normalizeUrl(url)); | |||
There was a problem hiding this comment.
Just an extraneous call I noticed, since this is already done 4 lines up
Fixes microsoft/vscode#170412 We were not rebasing remote paths correctly in the initial launch, which caused the fallback logic to kick in and manually apply skipFiles to every single script (and recompile globs), which was quite slow. And add a test that I wrote while barking up the wrong tree.
connor4312
force-pushed
the
fix/remote-skipfiles
branch
from
7a311ed
to
b711bf0
Compare
roblourens
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#170412
We were not rebasing remote paths correctly in the initial launch, which caused the fallback logic to kick in and manually apply skipFiles to every single script (and recompile globs), which was quite slow.
And add a test that I wrote while barking up the wrong tree.