Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unbound breakpoints in sourcemaps on Chrome 112 #1580

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

connor4312
Copy link
Member

Chrome Dev (112) no longer has any stackframes for instrumentation
breakpoints, which was resulting in a thrown error.

Fixes #1567

Chrome Dev (112) no longer has any stackframes for instrumentation
breakpoints, which was resulting in a thrown error.

Fixes #1567
@connor4312 connor4312 merged commit 581f645 into main Feb 28, 2023
@connor4312 connor4312 deleted the connor4312/issue1567 branch February 28, 2023 19:50
@joj
Copy link
Member

joj commented Mar 3, 2023

@connor4312 does this mean that any old version of VS and VSCode will fail with newer versions of Chrome? Should we let people in Chromium know about this? This feels like something that has the potential of breaking every IDE that supports CDP, not just ours :)

@connor4312
Copy link
Member Author

does this mean that any old version of VS and VSCode will fail with newer versions of Chrome

Yes. It would break any client who uses instrumentation breakpoints and assumes (without checking) that there is at least one call frame on every pause event. I don't know how widely used this pattern is, but I sent a mail to someone on their team whom I've talked to recently regarding instrumentation pauses.

@connor4312
Copy link
Member Author

Fyi, Chrome has rolled this back in 112 https://bugs.chromium.org/p/chromium/issues/detail?id=1421661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unbound breakpoints only when putting the breakpoints before debugging
3 participants