chore: remove webpack and tsb, use esbuild #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fortunately we don't depend on any extension global in integration tests, so moving over was relatively easy. Also adopt the esbuild- powered `tsx` loader for mocha unit tests. - 馃樆 Build time 50s -> 1.4s - 馃殌 Extension.js size 1,630KB -> 1280KB -- mostly better treeshaking Fixes #1575
connor4312
force-pushed
the
chore/move-to-esbuild
branch
from
6289ffa
to
d039754
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| cwd: args.pluginData.resolveDir, | ||
| }) | ||
| .sort() | ||
| .map(m => `[${JSON.stringify(m)}, () => import(${JSON.stringify(`./${m}`)})]`); |
Check warning
Code scanning / CodeQL
Improper code sanitization
|
CodeQL checks are a couple false positives and it tripping over test fixtures |
rebornix
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fortunately we don't depend on any extension global in integration tests, so moving over was relatively easy. Also adopt the esbuild- powered
tsxloader for mocha unit tests.Fixes #1575