Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: silent error if runtimeExecutable crashes with useWebView: true #1691

Merged
merged 1 commit into from
May 3, 2023
Merged

fix: silent error if runtimeExecutable crashes with useWebView: true #1691

merged 1 commit into from
May 3, 2023

Conversation

connor4312
Copy link
Member

Fixes #1666

@connor4312 connor4312 enabled auto-merge (squash) May 3, 2023 17:28
@connor4312
Copy link
Member Author

TEst failure is an existing one in main, will fix that in a separate PR

@connor4312 connor4312 merged commit 2c2f2d8 into main May 3, 2023
6 of 10 checks passed
@connor4312 connor4312 deleted the connor4312/issue1666 branch May 3, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lramos15 lramos15 lramos15 approved these changes

Assignees

@connor4312 connor4312

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With useWebView=true, debug session stays open indefinitely if program exits before a webview is attached
2 participants
@connor4312 @lramos15