fix: possible bad state when resuming multiple times with a slow client #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some requests can make the client application run slow. If the user tries to resume multiple times when paused and "stuck", it's very easy to get into a bad state. With this change, coalesce multiple requests of the same type together so that clicking resume while stalled doesn't tear the state. I couldn't really get a consistent test case for this since it's timing based :/ Found while investigating #1719
lramos15
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some requests can make the client application run slow. If the user
tries to resume multiple times when paused and "stuck", it's very easy
to get into a bad state.
With this change, coalesce multiple requests of the same type together
so that clicking resume while stalled doesn't tear the state.
I couldn't really get a consistent test case for this since it's
timing based :/
Found while investigating #1719