Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: child processes from extension host not getting spawned during debug #1767

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: child processes from extension host not getting spawned during debug #1767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

This changelog records changes to stable releases since 1.50.2. "TBA" changes here may be available in the [nightly release](https://github.com/microsoft/vscode-js-debug/#nightly-extension) before they're in stable. Note that the minor version (`v1.X.0`) corresponds to the VS Code version js-debug is shipped in, but the patch version (`v1.50.X`) is not meaningful.

## Nightly (only)

- fix: child processes from extension host not getting spawned during debug

## v1.81 (July 2023)

- fix: child process tree not terminating on all Linux distros ([#1747](https://github.com/microsoft/vscode-js-debug/issues/1747))
Expand Down
4 changes: 3 additions & 1 deletion src/targets/node/extensionHostAttacher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,14 @@ export class ExtensionHostAttacher extends NodeAttacherBase<IExtensionHostAttach
return;
}

const vars = await this.resolveEnvironment(
let vars = await this.resolveEnvironment(
run,
new NodeBinary('node', Semver.parse(process.versions.node)),
{ openerId: targetId },
);

vars = vars.update('ELECTRON_RUN_AS_NODE', null);

for (let retries = 0; retries < 200; retries++) {
const result = await cdp.Runtime.evaluate({
contextId: 1,
Expand Down
Loading