Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve protocol handling performance in all cases #2002

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

connor4312
Copy link
Member

Please observe this scientific comparison of rename performance in the copilot chat repo:

image

Closes #2001

@connor4312 connor4312 enabled auto-merge (squash) April 26, 2024 18:31
@@ -712,4 +716,46 @@ describe('node runtime', () => {
handle.assertLog({ substring: true });
});
});

describe('etx', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realized we didn't actually have test cases for these before

@connor4312 connor4312 merged commit f82c9eb into main Apr 26, 2024
3 of 7 checks passed
@connor4312 connor4312 deleted the connor4312/issue-2001 branch April 26, 2024 18:33
@roblourens
Copy link
Member

#meme or #performance

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The split2 module is very slow when handling large amounts of CDP data
4 participants