Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support opening an HTML page #78

Merged
merged 1 commit into from Nov 11, 2019

Conversation

connor4312
Copy link
Member

@connor4312 connor4312 commented Nov 7, 2019

This adds support for the "file" option in Chrome's launch.json to open
and HTML page. Support for this was straightforward. I also did some
work on the config providers to make HTML pages F5-able without needing
a preexisting launch configuration.

Kapture 2019-11-07 at 11 56 23

There's an outstanding issue where breakpoints set before Chrome is launch are sent to Chrome, but don't seem to apply. Pinged Dmitry for ideas on this, seems like some kind of race. #79

This adds support for the "file" option in Chrome's launch.json to open
and HTML page. Support for this was straightforward. I also did some
work on the config providers to make HTML pages F5-able without needing
a preexisting launch configuration.
@connor4312 connor4312 merged commit 27e374c into feat/generate-debuggers Nov 11, 2019
@connor4312 connor4312 deleted the feat/open-by-file branch November 11, 2019 21:48
@plche
Copy link

plche commented Jun 17, 2021

This adds support for the "file" option in Chrome's launch.json to open
and HTML page. Support for this was straightforward. I also did some
work on the config providers to make HTML pages F5-able without needing
a preexisting launch configuration.

Kapture 2019-11-07 at 11 56 23

There's an outstanding issue where breakpoints set before Chrome is launch are sent to Chrome, but don't seem to apply. Pinged Dmitry for ideas on this, seems like some kind of race. #79

My apologies in advance if this is not the right place to post this (wanted to keep the context): Can't get to replicate this in Ubuntu 20.04.2 LTS, Linux kernel 5.4.0-74-generic SMP x86_64 GNU/Linux, VS Code 1.57.0, Debugger for Chrome (msjsdiag.debugger-for-chrome) v4.12.12 extension and Google Chrome 91.0.4472.106 (Official Build) (64-bit) - JavaScript V8 9.1.269.36. Breakpoint can't get hit and it reads Unbound breakpoint, take a look at the following image:

pwa-chrome-simple-html

I'm attaching also the log file of the trace: pwa-chrome-simple-html.log

Any feedback/guideline to make it work would be appreciated. Thanks in advance!

@connor4312
Copy link
Member Author

@piche please try the nightly build, there are fixes that went in recently.

@plche
Copy link

plche commented Jun 17, 2021

Dear @connor4312, same behavior/results, this is the log: pwa-chrome-simple-html.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants